react-financial-charts icon indicating copy to clipboard operation
react-financial-charts copied to clipboard

Published 20 hours ago • verified publisher icon react-financial

Conflict with react^18

Open SamAbaasi opened this issue 3 years ago • 3 comments

Conflict with react^18

SamAbaasi avatar Jul 26 '22 15:07 SamAbaasi

This would be great to get this working with React 18 as we need to upgrade our site

sjclark76 avatar Aug 15 '22 20:08 sjclark76

+1

sasha-id avatar Sep 13 '22 04:09 sasha-id

Heads up, this fork and branch is for react 18, not sure if it's ready, but using it could help validate that it's ready for a PR https://github.com/adamhwang/react-financial-charts/tree/react18

GitHub
Charts dedicated to finance. Contribute to adamhwang/react-financial-charts development by creating an account on GitHub.

ferrants avatar Sep 15 '22 04:09 ferrants

@ferrants can you PR this patch?

dulabs avatar Dec 23 '22 05:12 dulabs

@dulabs here you go https://github.com/react-financial/react-financial-charts/pull/668

ferrants avatar Dec 23 '22 18:12 ferrants

Bump ^

Can we merge the PR?

dmytro-y-dev avatar Mar 19 '23 15:03 dmytro-y-dev

Bump ^

Can we merge the PR?

GOATsann avatar Apr 30 '23 03:04 GOATsann

there's a comment on the PR that's waiting to be resolved before being merged.

markmcdowell avatar Apr 30 '23 07:04 markmcdowell

Resolved in v2.0.0

markmcdowell avatar May 12 '23 08:05 markmcdowell