react-financial-charts fix: added .js to all file import/exports

fix: added .js to all file import/exports

Open adamhwang opened this issue 3 years ago • 7 comments

To address ESM module resolution needs: https://github.com/react-financial/react-financial-charts/issues/606

Checklist

[x] My commits follow Conventional Commits
[ ] documentation is updated

Dec 22 '21 14:12 adamhwang

I've confirmed this is a comprehensive changeset with eslint-plugin-import. I cannot check-in the eslint rules without rebuilding the package-lock as its an older version than I have available.

If you're interested in confirming / adding, the package is eslint-plugin-import with the following additions to .eslintrc.yaml:

extends:
  - "plugin:import/warnings"
  - "plugin:import/typescript"
rules:
  "import/extensions":
    - 2
    - "always"

Dec 23 '21 01:12 adamhwang

Any chance this will be merged and released in the near future?

Mar 15 '22 16:03 fasmat

Any chance this will be merged and released in the near future?

It currently does not build, and needs a rebase to fix conflicts. I'm tempted to revert the package.json flag instead.

Jul 12 '22 21:07 markmcdowell

It currently does not build, and needs a rebase to fix conflicts. I'm tempted to revert the package.json flag instead.

I rebased and added the lint rule, but unfortunately appear to be running into this jest issue with the test: https://github.com/kulshekhar/ts-jest/issues/1057

ETA: fixed the test. it's not ideal, but none of this has been 😅

Jul 12 '22 22:07 adamhwang

this library has been broken for months because of this. Please @markmcdowell release a new version 🙏