file-selector icon indicating copy to clipboard operation
file-selector copied to clipboard

Published 20 hours ago • verified publisher icon react-dropzone

feat: convert package to pure ESM

Open jonkoops opened this issue 3 years ago • 6 comments

What kind of change does this PR introduce?

  • [ ] Bug Fix
  • [x] Feature
  • [ ] Refactoring
  • [ ] Style
  • [ ] Build
  • [ ] Chore
  • [ ] Documentation
  • [ ] CI

Did you add tests for your changes?

  • [x] Yes, my code is well tested
  • [ ] Not relevant

If relevant, did you update the documentation?

  • [x] Yes, I've updated the documentation
  • [ ] Not relevant

Summary This converts the package into pure ESM. This means that the code is no longer distributed as anything than standard JavaScript, avoiding dual packaging hazard in the process.

This also benefits modern bundlers such as Vite, which can do more extensive optimizations on pure packages.

Does this PR introduce a breaking change? Yes, this raises the minimum required version of Node.js to version 14. Since Node.js 12 is EOL this should not be an issue. This also drop support for all module systems beside ECMAScript.

jonkoops avatar Sep 11 '22 15:09 jonkoops

@rolandjitsu any particular reason the PR was closed?

jonkoops avatar Feb 18 '24 17:02 jonkoops

Sorry, that was unintentional. The intent was to close the dependapot ones. Re-opening.

rolandjitsu avatar Feb 19 '24 02:02 rolandjitsu

@rolandjitsu I think I will split out this PR into a couple of smaller more reviewable ones. It's also been a while since this PR was created, so I'd like to re-evaluate the choices made here.

jonkoops avatar Feb 29 '24 14:02 jonkoops

Marking this as a draft to get back to it later when the other work has landed.

jonkoops avatar Mar 02 '24 17:03 jonkoops