cascader icon indicating copy to clipboard operation
cascader copied to clipboard

feat: add disabled api for panel

Open aojunhao123 opened this issue 1 year ago • 3 comments

Cascader底层组件rc-cascader的Panel模式支持传入disabled去禁用整个Panel区域

Summary by CodeRabbit

  • 新特性

    • Cascader.Panel 组件中添加了 disabled 属性,允许用户设置面板为非交互状态。
    • 增强了 Column 组件的功能,支持 panelDisabled 属性,以更好地管理选项的禁用状态。
  • 测试

    • Cascader.Panel 组件添加了新的测试用例,以验证禁用状态的行为。

aojunhao123 avatar Oct 16 '24 15:10 aojunhao123

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cascader ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 11:07am

vercel[bot] avatar Oct 16 '24 15:10 vercel[bot]

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

此拉取请求引入了对多个组件的更改,主要是为 Cascader.Panel 组件添加了一个新的 disabled 属性,以表示该面板为非交互式。同时,Column 组件的 ColumnProps 接口也更新,以支持新的 disabled 属性,影响选项的交互逻辑。其他相关组件的类型和逻辑也进行了相应的调整,以确保新的禁用状态在整个组件中一致地处理。此外,还为 Cascader.Panel 组件添加了新的测试用例,以验证禁用状态的正确性。

Changes

文件路径 更改摘要
examples/panel.tsx 添加 Cascader.Paneldisabled 属性,创建一个新的非交互式面板实例,并添加按钮以切换禁用状态。
src/OptionList/Column.tsx ColumnProps 接口中添加 disabled 属性,更新 Column 组件以使用该属性,修改选项交互逻辑。
src/OptionList/List.tsx 更新 RawOptionListProps 类型,添加 disabled 属性并修改选择逻辑以考虑该属性。
src/Panel.tsx 更新 PickTypePanelProps 类型,添加 disabled 属性,确保 RawOptionList 组件可以利用该属性。
tests/Panel.spec.tsx Cascader.Panel 组件添加新的测试用例,验证在 disabled 属性为 true 时的行为及样式。

Poem

在兔子洞里欢声笑,
新属性来真是妙。
面板禁用不再忙,
选项交互更轻松。
代码更新如春风,
兔子跳跃乐无穷! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Oct 16 '24 15:10 coderabbitai[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.83%. Comparing base (4b44dba) to head (7691896). Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #543   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files          23       23           
  Lines         611      614    +3     
  Branches      185      177    -8     
=======================================
+ Hits          610      613    +3     
  Misses          1        1           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 17 '24 02:10 codecov[bot]