react-overlays icon indicating copy to clipboard operation
react-overlays copied to clipboard

Add wrapperRender method to Modal component

Open vileven opened this issue 5 years ago • 4 comments

This PR contains new method to Modal component. It's usefull for me adding wrapper to Modal component (including backdrop), so I just forked and add some

vileven avatar Sep 06 '20 20:09 vileven

Hi, thanks for the PR. I'm not sure i understand what this adds or unlocks. You can already control the rendering of each as well as the portal container

jquense avatar Sep 08 '20 13:09 jquense

Hi, thanks for the PR. I'm not sure i understand what this adds or unlocks. You can already control the rendering of each as well as the portal container

I need to have a wrapper, due to the design of my modals (I think it doesn't really matters why. But in case you're interested, it's because they have to add a scrollbar if they don't fit on the page).

Each modal should have a wrapper...

and of course, I can use container. But in that container, I should implement container prop pretty similar inside this library. And I get a very complex structure with two ReactDOM.createPortal and so on. So, I decided to fork library and add wrapper here.

vileven avatar Sep 28 '20 07:09 vileven

thoughts folks?

jquense avatar Sep 28 '20 12:09 jquense

Hmm I'm not sure about this. I'm thinking it should be possible to handle the scrolling using the current rendering API, but maybe it's easier to visualize with an example?

kyletsang avatar Sep 29 '20 00:09 kyletsang