poorman
poorman copied to clipboard
Comments cause immediate termination
Run poorman start with this Procfile:
# This is a comment
foo: sleep 3
bar: sleep 3
baz: sleep 3
It should wait three seconds and then terminate, but instead it terminates immediately. This appears to be because the first line is being parsed as a command - parse_procfile_line of a string without a : sets both the name and the command to the full string. The command # This is a comment then terminates immediately, causing poorman itself to terminate.
At the moment we're dealing with this by pinning to 4ec7771aad87be5725464fb47f3a42de2ecda27c; the next commit, which rewrites the parser, introduces the problem.
Thanks for the writeup! Given that poorman has a lot of tests, we should be able to readily write a test for it.
I'm reopening based on @groner's comments. https://github.com/rduplain/poorman/commit/98b646db58967a8efffa6d20ab1597cc71e36c56#commitcomment-21167082