Ruslan Diachenko

Results 32 comments of Ruslan Diachenko

> One solution for big new projects is also (since 2.0): > http://jenkins.thetaphi.de/job/Forbidden-APIs/javadoc/check-mojo.html#failOnViolation > It would report violations, but not fail build. So you have enough time to clean up...

How about using Optional for Case 1? Created a draft PR to check it https://github.com/checkstyle/checkstyle/pull/13733 Regarding Case 2, I haven't checked it in details. Can't we cover it by a...

> user should see is comment as red flag of attention. > All other lines are without attention, as no violation on them, on all of them. +1

> This PR can be closed as it is solved by this PR - #14452 You are linking to the current PR. @RatikaDogra please take a look at the commets...

@MANISH-K-07 > Without casting return type, we find new surviving mutations like the one below for example You don't need casting here. What you see is that after making `getNextToken`...

@MANISH-K-07 please take a look at the ci failure https://github.com/checkstyle/checkstyle/actions/runs/7716830649/job/21034568468?pr=14387. Your change produced new mutations.

> Github, generate report @MANISH-K-07 please read this https://github.com/checkstyle/contribution/tree/master/checkstyle-tester#basic-difference-report-with-label-and-custom-projects-list and check other PRs where report was generated, you need to update PR description with needed configs in order to automatically...

@MANISH-K-07 what's the status on this? Do you need help?

@Zopsss please fix ci, there are errors related to spellchecker: ``` ... There are now fewer misspellings than before. config/jsoref-spellchecker/whitelist.words could be updated: patch 'config/jsoref-spellchecker/whitelist.words'

> unless it is part of a multi-block statement (one that directly contains multiple blocks: if/else or try/catch/finally) We should also cover these cases: ```java if (condition1) { foo(); }...