types icon indicating copy to clipboard operation
types copied to clipboard

Update stream.d.ts so Stream extends AsyncIterable<Quad>

Open gobengo opened this issue 1 year ago • 6 comments

it might be a good idea to have it extend from stream.Readable too, but this is less opinionated. (node Readable implements AsyncIterable<Q>)

gobengo avatar Dec 26 '23 02:12 gobengo

⚠️ No Changeset found

Latest commit: 090d2d39691402510792aeee2347e21e72ede9b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Dec 26 '23 02:12 changeset-bot[bot]

wdyt @rubensworks ?

gobengo avatar Dec 26 '23 02:12 gobengo

re https://github.com/rdfjs/types/issues/6

tpluscode avatar Dec 27 '23 08:12 tpluscode

Would be so handy! 👌

woutermont avatar Jan 05 '24 09:01 woutermont

The types should always follow the WebIDL definitions in the specifications. Therefore, the stream spec would be the right place to discuss this topic.

If you consider making a proposal, address the concerns regarding performance expressed by the author of a widely used RDF/JS package.

bergos avatar Jan 07 '24 08:01 bergos

@gobengo I agree this could be useful, but as mentioned by @bergos, we should first add this to the streams spec, which requires concensus in the RDF/JS that this is the direction we want to go towards. The performance issue raised in https://github.com/rdfjs/types/issues/6 may not be present anymore, but this would require some investigation.

rubensworks avatar Jan 08 '24 13:01 rubensworks