rdb

Results 467 comments of rdb

I'm a little on the fence about calling `GraphicsEngine::remove_all_windows()` here. I feel like it would be more consistent with the other implementations to instead just close the windows associated with...

Two observations: * Cocoa *does* close all the windows, but we don't actually implement `windowWillClose` in the window delegate, which is why close_window doesn't run * It doesn't appear that...

@el-dee I've pushed your first fix (calling `remove_all_windows()`) to the release/1.10.x branch and some additional changes so that the finalizeExit handler runs properly on Command+Q. In fact, applicationWillTerminate will probably...

Going to un-assign this from 1.10.13 until this is verified to be either still broken or already fixed.

I see no advantage of using `.getValue()` over `.value`. The latter is faster, less visually cluttered, and naming convention agnostic. I reckon we will eventually deprecate the former in favour...

What's the status on this PR? It would probably be really useful to have the FMOD update split out from the DSP system changes

Still interested in splitting this, or should someone else take over the work? Would be nice to have the FMOD update in 1.11.

Thanks for your contribution. I've finished the remaining work and pushed it to master.

It appears that in M1, the OpenGL driver is actually based on top of Metal, which uses CAMetalLayer, which doesn't support the CGL full-screen APIs, that's why it doesn't work....