Richard Crowley

Results 32 comments of Richard Crowley

No, I don't believe there's a way to get at that. If you find a way to make that available that's API-compatible I'd merge it.

I poked around a bit with `iconv`(1) (character sets are mysterious beasts and my shell loves UTF-8) and I think this confirms the issue. Note the extra `0a` in the...

This pull request is broken: It changes one of the imports to your namespace. Please fix it.

This might not make sense unless it gets bubbled all the way up to the functions registered with Marshaled and making those interruptible will definitely complicate the API.

This seems like a good use of tags. I like it.

Actually, instead of having to embed `NilRedactor`, we could `redactor, ok := request.(Redactor)` to keep the no-redactor-necessary case simple.

The `Request` and `Response` interfaces have been removed.

This might not make sense unless it gets bubbled all the way up to the functions registered with `Marshaled` and making those interruptible will definitely complicate the API.

I honestly don't. I've seen it in logs for _non_-Tiger Tonic services before, too, though, so the problem may be more subtle. Or it may not be a problem at...

I obviously agree but don't have time. Hopefully http://godoc.org/github.com/rcrowley/go-tigertonic helps out a bit, too.