react-native-vlc-media-player icon indicating copy to clipboard operation
react-native-vlc-media-player copied to clipboard

Get aspect ratio

Open lule-steph opened this issue 4 years ago • 2 comments

Hi

To use your nice lib I need to get aspect ratio of the video.

Indeed if we don't know it how do you compute height of the component ?

Thank you

lule-steph avatar Mar 19 '21 18:03 lule-steph

I see that can be a issue, buy usually the meta data should have most of those info. Other thing is I usually just use the full available space and set the ratio according to the space and play it in there regardless of original aspect ratio. But I understand that won’t always be an option. What I would suggest is investigate the vlc original lib and see if they have an option if so update the lib to use those. I will be more than happy to accept PRs. Sorry couldn’t help you more as I am tide up with million other things at the moment, but I am pretty sure if you put a bounty someone will sort it out

Cheers

On Sat, 20 Mar 2021 at 7:26 AM, lule-steph @.***> wrote:

Hi

To use your nice lib I need to get aspect ratio of the video.

Indeed if we don't know it how do you compute height of the component ?

Thank you

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/razorRun/react-native-vlc-media-player/issues/63, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFB72EE3YZ3AHCV655Z7HJDTEOJMZANCNFSM4ZPJGPJA .

razorRun avatar Mar 19 '21 19:03 razorRun

Thank you for your answer!

Could you please provide some useful links for the vlc original lib so I can investigate in that direction.

If I find a solution it will be a pleasure to provide a PR !

lule-steph avatar Mar 20 '21 06:03 lule-steph