extensions icon indicating copy to clipboard operation
extensions copied to clipboard

[GitHub] Show notification bar in GitHub UI when opening a notification in browser

Open tom-sherman opened this issue 1 year ago β€’ 8 comments

Extension

https://www.raycast.com/raycast/github

Description

It would be great if when I open a notification from the menubar or command in my browser that I get the same experience as when navigating from the GitHub web notification list

image

Who will benefit from this feature?

Will allow me to easily organise notifications by eg. marking them as done.

Anything else?

No response

tom-sherman avatar Apr 11 '24 09:04 tom-sherman

Thank you for opening this issue!

πŸ”” @thomaslombart @unnamedd @tonka3000 @khasbilegt @pernielsentikaer @loxygenK @oilbeater @LunaticMuch @aeorge @daquinoaldo @peppy @aeither @marcotf @qeude @nesl247 @xilopaint @antonengelhardt @bangerang you might want to have a look.

πŸ’‘ Author and Contributors commands

The author and contributors of raycast/github can trigger bot actions by commenting:

  • @raycastbot close this issue Closes the issue.
  • @raycastbot rename this issue to "Awesome new title" Renames the issue.
  • @raycastbot reopen this issue Reopen the issue.

raycastbot avatar Apr 11 '24 09:04 raycastbot

I noticed that too, but the issue is that, we show all notifications (grouped by read/unread) including done notifications instead of only "undone" ones:

const {
    data,
    isLoading,
    mutate: mutateList,
  } = useCachedPromise(async () => {
    const response = await octokit.rest.activity.listNotificationsForAuthenticatedUser({ all: true });
    return response.data;
  });

If you can change that to all: false, then only unread notifications show up and not "undone" notifications.

But generally i am in favor of showing only undone notifications and then sort them by read/unread.

antonengelhardt avatar Apr 11 '24 09:04 antonengelhardt

When I navigate to a done notification from the GitHub UI I also get a banner, could a navigation from Raycast match this behaviour?

image

Like you though, I personally have no need for seeing done notifications in Raycast.

tom-sherman avatar Apr 11 '24 09:04 tom-sherman

It won't be possible to show a navigation banner like GitHub's UI. However, we can certainly add more actions in the Action Panel like the Unsubscribe one (so we'd need to probably call this endpoint). Not sure about the Save action as I didn't found anything in the GitHub's API.

thomaslombart avatar Apr 11 '24 10:04 thomaslombart

Unsubscribe is already there:

Screenshot-CleanShot-006600@2x

I think it would be very useful, if the Github extension actually replicated the grouping of the GitHub Web UI, meaning that we group by unread/read/done. Currently, i see all notifications in my extension. I tick them off in the web ui and also in GH mobile app. But they still appear in the Read Section in the extension... What do you think?

antonengelhardt avatar Apr 11 '24 13:04 antonengelhardt

Unsure if this even possible, as the notification object doesn't include any info if its done or not. Same for the endpoint listNotificationsForAuthenticatedUser(), which has the filter, but it only filters away read notifications. Hmm

antonengelhardt avatar Apr 11 '24 13:04 antonengelhardt

Oh yeah, true. I didn't even remember I added it πŸ˜„

Unfortunately, the GitHub notifications API is limited so not sure we can do something here…

thomaslombart avatar Apr 11 '24 13:04 thomaslombart

lets see :)

antonengelhardt avatar Apr 11 '24 20:04 antonengelhardt

This issue has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 10 days to keep our backlog clean 😊

raycastbot avatar May 31 '24 20:05 raycastbot

This issue has been automatically closed due to inactivity.

Feel free to comment in the thread when you're ready to continue working on it πŸ™‚

You can also catch us in Slack if you want to discuss this.

raycastbot avatar Jun 10 '24 21:06 raycastbot