ray icon indicating copy to clipboard operation
ray copied to clipboard

when actor_id_ is nil ,call ray.get_runtime_context().actor_name will cause raise

Open 982945902 opened this issue 1 year ago • 14 comments
trafficstars

Why are these changes needed?

when actor_id_ is nil ,call ray.get_runtime_context().actor_name will cause raise

Related issue number

issue 45174

Checks

  • [x] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [x] I've run scripts/format.sh to lint the changes in this PR.
  • [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
    • [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in doc/source/tune/api/ under the corresponding .rst file.
  • [x] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [ ] Unit tests
    • [x] Release tests
    • [ ] This PR is not tested :(

982945902 avatar May 08 '24 06:05 982945902

@kevin85421 that good !

982945902 avatar May 09 '24 03:05 982945902

@kevin85421 ok

982945902 avatar May 09 '24 06:05 982945902

Would you mind rebasing with the master branch?

kevin85421 avatar May 11 '24 03:05 kevin85421

Would you mind rebasing with the master branch?

@kevin85421 not mind, how need i do

982945902 avatar May 11 '24 03:05 982945902

Take a look at your commit history. It seems to be that you don't sync with the master branch correctly. You may not need to rebase with the master branch, but you need to fix your commit history.

kevin85421 avatar May 11 '24 03:05 kevin85421

Hi @982945902, would you mind fixing the CI failure?

kevin85421 avatar May 13 '24 21:05 kevin85421

@kevin85421 It seems that some of the test cases timed out, causing the use cases to fail, how should I re-triggered the C test

982945902 avatar May 14 '24 03:05 982945902

It seems that some of the test cases timed out, causing the use cases to fail, how should I re-triggered the C test

I re-triggered CI pipeline multiple times for this PR. It always fails. Could you try to reproduce in your local env?

kevin85421 avatar May 16 '24 16:05 kevin85421

@kevin85421 These test cases have bugs, and someone merged and fixed them two days ago

982945902 avatar May 17 '24 02:05 982945902

@kevin85421 These test cases have bugs, and someone merged and fixed them two days ago

982945902 avatar May 17 '24 02:05 982945902

Would you mind rebasing with the master branch? Thanks!

kevin85421 avatar May 17 '24 05:05 kevin85421

Would you mind rebasing with the master branch? Thanks!

@kevin85421 not mind, how need i do

982945902 avatar May 17 '24 06:05 982945902

@kevin85421 not mind, how need i do

Sync your branch with the upstream master branch.

kevin85421 avatar May 17 '24 17:05 kevin85421

@kevin85421 done

982945902 avatar May 20 '24 06:05 982945902