ray icon indicating copy to clipboard operation
ray copied to clipboard

Published 20 hours ago • verified publisher icon ray-project

Numpy 1.24 Support

Open matthewdeng opened this issue 2 years ago • 1 comments

Context

Numpy 1.24.0 was released on 12/18/22 and contains some breaking changes. This ticket tracks the changes needed to ensure Ray is compatible - full compatibility is targeted for the 2.3 release.

Note: This version was released for Python 3.8-3.11, so code/tests using an earlier version (i.e. 3.7) will not surface these incompatibilities.

Failing Tests

  • https://github.com/ray-project/ray/issues/31193
  • https://github.com/ray-project/ray/issues/31194

Mitigation

  • https://github.com/ray-project/ray/pull/31240

Fixes

  • https://github.com/ray-project/ray/issues/31182
  • https://github.com/ray-project/ray/issues/31258
  • https://github.com/ray-project/ray/issues/31277

matthewdeng avatar Dec 20 '22 20:12 matthewdeng

I think the only remaining issues are #31182 and #31293.

  1. Why is there no test failing for this?
  2. Can we prioritize fixing that?

krfricke avatar Jan 03 '23 14:01 krfricke

@krfricke I'm on-call this week and will focus on #31293

ArturNiederfahrenhorst avatar Jan 09 '23 18:01 ArturNiederfahrenhorst

@matthewdeng I tested Numpy 1.24.2 with Ray 2.4.0 and it seems failed. Do we have a timeline to support this?

YQ-Wang avatar May 23 '23 23:05 YQ-Wang

@YQ-Wang can you share what you're running and what the error you're getting is?

matthewdeng avatar May 24 '23 00:05 matthewdeng

@matthewdeng Thanks for replying. I just want to confirm if 1.24.2 is fully supported because this ticket is not closed

YQ-Wang avatar May 24 '23 00:05 YQ-Wang

@YQ-Wang yes ray should be fully compatible with numpy 1.24, which is the version contains in the Docker images. As always, it is still possible that other dependencies maybe introduce incompatibilities with numpy.

If you run into any issues, please re-open this issue!

matthewdeng avatar May 25 '23 21:05 matthewdeng