ray icon indicating copy to clipboard operation
ray copied to clipboard

do not lump ImportError with ModuleNotFoundError

Open mattip opened this issue 3 years ago • 5 comments

Why are these changes needed?

Related issue number

Split out of PR #26295 to give a clearer warning when gpustat fails to import. There could be a test for the ImportError by setting up a virtualenv that includes ray and both gputstat==1.0.0rc1 and nvidia-ml-py3 and then importing the dashboard reporter_agent.

Checks

  • [x] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [x] I've run scripts/format.sh to lint the changes in this PR.
  • [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
  • [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [ ] Unit tests
    • [ ] Release tests
    • [x] This PR is not tested :(

mattip avatar Aug 04 '22 20:08 mattip

~All CI is passing, it seems readthedocs is stuck.~

mattip avatar Aug 05 '22 05:08 mattip

Windows CI is failing:

  • test_unpickleable_stacktrace is failing with RuntimeError: Failed to unpickle serialized exception
  • Some tests are timing out //python/ray/serve:test_long_poll, //python/ray/serve:tutorial_rllib, //python/ray/tests:test_basic_2, //python/ray/tests:test_multiprocessing, //python/ray/tests:test_iter, //python/ray/tests:test_asyncio, //python/ray/tests:test_advanced_4, //python/ray/tests:test_component_failures

mattip avatar Aug 05 '22 05:08 mattip

Documentation-only PR #27529 is also suffering from timeouts on windows.

mattip avatar Aug 05 '22 05:08 mattip

On windows, the test_reference_counting test is timing out. There are ~24 tests in that file. On my local machine, running the tests via pytest --durations 0 shows setup/call/teardown time for each test. The setup time is around 5 seconds, the teardown around 3. and the tests themselves range from 8 seconds to 0.05 seconds. Given that these tests are run as "medium", they will timeout after 300 seconds. So if the test run falls on a weak machine, it seems reasonable they should time out. @pcmoritz should I split the test file in two?

mattip avatar Aug 08 '22 10:08 mattip

I don;t think the test failures were caused by this PR.

mattip avatar Aug 10 '22 12:08 mattip

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

stale[bot] avatar Sep 17 '22 01:09 stale[bot]

Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message.

Please feel free to reopen or open a new issue if you'd still like it to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for opening the issue!

stale[bot] avatar Oct 01 '22 17:10 stale[bot]