kuberay
kuberay copied to clipboard
ray-project
[Feature] Replace kustomize with kubectl in E2E tests.
Search before asking
- [X] I had searched in the issues and found no similar feature requirement.
Description
We use kustomize in tests/kuberay_utils/utils.py. However, kustomize has already been integrated with kubectl (Link). Hence, we can replace kustomize commands with kubectl commands to avoid redundant dependencies.
Use case
No response
Related issues
No response
Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
kustomize provides sdk and if you prefer to use programming way, you can adopt it as well. For command line execution, kubectl kustomize definitely makes more sense
kustomize provides sdk and if you prefer to use programming way, you can adopt it as well. For command line execution,
kubectl kustomizedefinitely makes more sense
Thank @Jeffwan for this information! I try to search for Python SDK for Kustomize. I found python-kustomize, but the project is not under maintenance. Is there any other Python Kustomize SDK? Thanks!
I found that kubectl only supports applying kustomization.yaml instead of creating and editing kustomization.yaml, which is utilized in tests/kuberay_utils/utils.py. If we want to get rid of kustomize, we might need to create a template kustomization.yaml and use JSON Patch to update it.
I found that kubectl only supports applying kustomization.yaml instead of creating and editing kustomization.yaml, which is utilized in tests/kuberay_utils/utils.py. If we want to get rid of kustomize, we might need to create a template kustomization.yaml and use JSON Patch to update it.
Good point. I think the possible solutions are: (1) Use kustomize Python SDK (2) Use JSON Patch
Gentle ping @Jeffwan
Is there any other Python Kustomize SDK? Thank you!
Close this issue because Kustomize has been removed from existing tests in https://github.com/ray-project/kuberay/pull/759.