kuberay icon indicating copy to clipboard operation
kuberay copied to clipboard

[Feat] TTL Delete RayJob CRD After Job Termination #1944

Open Xiao75896453 opened this issue 1 year ago • 2 comments
trafficstars

Why are these changes needed?

add deleting RayJob CRD at JobDeploymentStatusComplete case

Related issue number

#1944

Checks

  • [ ] I've made sure the tests are passing.
  • Testing Strategy
    • [ ] Unit tests
    • [ ] Manual tests
    • [x] This PR is not tested :(

Xiao75896453 avatar Apr 21 '24 08:04 Xiao75896453

@rueian @kevin85421

Xiao75896453 avatar Apr 21 '24 08:04 Xiao75896453

Deleting the RayJob CR after TTLSecondsAfterFinished seems to solve the original issue. What do you think @kevin85421? If you agree with the approach, @Xiao75896453 can then finish this PR with corresponding tests.

rueian avatar Apr 21 '24 09:04 rueian

@MortalHappiness will take over this issue. Close this PR.

kevin85421 avatar Jul 02 '24 16:07 kevin85421