kuberay icon indicating copy to clipboard operation
kuberay copied to clipboard

Published 20 hours ago • verified publisher icon ray-project

fix: avoid hard-code Prometheus datasource id

Open hustshawn opened this issue 1 year ago • 4 comments

Why are these changes needed?

Currently the kuberay-api-server and kuberay-controller-runtime Grafana dashboard hard coded the Prometheus data source id, which is not re-usable by people. Fixed the hard code.

Related issue number

Checks

  • [x] I've made sure the tests are passing.
  • Testing Strategy
    • [ ] Unit tests
    • [x] Manual tests
    • [ ] This PR is not tested :(

hustshawn avatar Mar 25 '24 15:03 hustshawn

Would you mind providing more details about how you test this PR manually? These two files are not mentioned in the Ray documentation. In addition, these files haven't been updated for two years, so I am unsure whether they work or not. I need to manually test this PR.

kevin85421 avatar Mar 26 '24 00:03 kevin85421

Thanks @kevin85421 . Steps include,

  1. Setup the Prometheus and Grafana. follow this doc
  2. In Grafana, import the dashboard as the snapshot. Copy and past the Json mentioned and import image

hustshawn avatar Mar 26 '24 03:03 hustshawn

cc @Yicheng-Lu-llll would you mind reviewing this PR?

kevin85421 avatar Mar 28 '24 00:03 kevin85421

Setup the Prometheus and Grafana. follow this doc

The document doesn't include any service monitor or Pod monitor for the KubeRay operator Pod. Is Prometheus able to fetch the metrics?

kevin85421 avatar Mar 30 '24 02:03 kevin85421