NULL pointer dereference in scanvideo_begin_scanline_generation

[Memotech-Bill]

If:

• routine scanvideo_begin_scanline_generation is called with block = false,
• there are no available buffers on shared_state.free_list.free_list
• and PICO_SCANVIDEO_LINKED_SCANLINE_BUFFERS is true

then at line 1092 of scanvideo,c:

• the variable fsb is NULL
• and is dereferenced.

This line should probably be moved up to line 1081.

[kilograham]

ha, yes i've definitely never tried that :-)

[Memotech-Bill]

I haven't tried it either :)

I don't even know what PICO_SCANVIDEO_LINKED_SCANLINE_BUFFERS is for. I am just reading through the code, trying to understand it, and spotted that.