openocd icon indicating copy to clipboard operation
openocd copied to clipboard

Published 20 hours ago • verified publisher icon raspberrypi

Allow any gpio pin to be used (not just the first 32)

Open georgeharker opened this issue 1 year ago • 5 comments

Previous implementation disallowed using higher pin numbers for srst etc, this removes that restriction

replaces https://github.com/raspberrypi/openocd/pull/113

georgeharker avatar Oct 02 '24 19:10 georgeharker

Is the motivation for this PR to be able to use this with the additional GPIO pins that are exposed on the Compute Modules?

lurch avatar Oct 03 '24 09:10 lurch

I've just noticed that this PR introduces a mix of tabs vs. spaces for indentation. IMHO it's best to be consistent (so stick to tabs, as that's what the original code was using).

lurch avatar Oct 03 '24 09:10 lurch

Is the motivation for this PR to be able to use this with the additional GPIO pins that are exposed on the Compute Modules?

Yes, I have a board which is pin constrained and I needed to be able to use GPIO 44 as the reset pin... it wasn't initially clear that the request to do so was silently ignored. In theory any pin should be usable... hence the PR

georgeharker avatar Oct 10 '24 16:10 georgeharker

I've just noticed that this PR introduces a mix of tabs vs. spaces for indentation. IMHO it's best to be consistent (so stick to tabs, as that's what the original code was using).

Thanks, fixed. I usually have my editor set up to auto convert, missed that in the diff.

georgeharker avatar Oct 10 '24 16:10 georgeharker

I've just noticed that this PR introduces a mix of tabs vs. spaces for indentation. IMHO it's best to be consistent (so stick to tabs, as that's what the original code was using).

this should now be fixed

georgeharker avatar Oct 16 '24 15:10 georgeharker