noobs icon indicating copy to clipboard operation
noobs copied to clipboard

Non-translated strings

Open lurch opened this issue 6 years ago • 5 comments

The QMessageBox here doesn't use the tr stuff, and so will always be displayed in English, even if NOOBS is set to a different language.

lurch avatar Jan 09 '19 10:01 lurch

That's an internal error that should never occur though.

The fact that it sometimes does is probably a bug here: https://github.com/raspberrypi/noobs/blob/master/recovery/main.cpp#L85 Probably needs a && !devname.endsWith("0") to catch partitionless SD cards.

maxnet avatar Jan 09 '19 11:01 maxnet

What about partitionless USB sticks? Will they need an extra condition? (I imagine some users will be able to create such things!)

procount avatar Jan 10 '19 10:01 procount

Looks like the code already skips e.g. /dev/sda (because we'd want /dev/sda1) and I think the change @maxnet is suggesting might mean it would also skip /dev/mmcblk0 (because we'd want /dev/mmcblk0p1)

lurch avatar Jan 10 '19 11:01 lurch

Not skip, but include. It should also look on mmcblk0

maxnet avatar Jan 10 '19 12:01 maxnet

Ah, I only skimmed the code quickly :wink:

lurch avatar Jan 10 '19 12:01 lurch