noobs
noobs copied to clipboard
Non-translated strings
The QMessageBox here doesn't use the tr stuff, and so will always be displayed in English, even if NOOBS is set to a different language.
That's an internal error that should never occur though.
The fact that it sometimes does is probably a bug here: https://github.com/raspberrypi/noobs/blob/master/recovery/main.cpp#L85
Probably needs a && !devname.endsWith("0") to catch partitionless SD cards.
What about partitionless USB sticks? Will they need an extra condition? (I imagine some users will be able to create such things!)
Looks like the code already skips e.g. /dev/sda (because we'd want /dev/sda1) and I think the change @maxnet is suggesting might mean it would also skip /dev/mmcblk0 (because we'd want /dev/mmcblk0p1)
Not skip, but include. It should also look on mmcblk0
Ah, I only skimmed the code quickly :wink: