rmm icon indicating copy to clipboard operation
rmm copied to clipboard

[FEA] Remove factory functions from resource adaptors

Open mhaseeb123 opened this issue 1 year ago • 3 comments

Consider removing factory functions with constructors in prefetch_resource_adaptor, statistics_resource_adaptor, logging_resource_adaptor and others in rmm.

More context at:

         question: can't this just be a constructor? > Why do we need a factory function?

Originally posted by @jrhemstad in https://github.com/rapidsai/rmm/pull/1608#discussion_r1674886164

### Tasks
- [x] Change calls to adaptor factories across RAPIDS repos to use constructors
- [ ] https://github.com/rapidsai/rmm/issues/1641
- [ ] Remove deprecated adaptor factories in 24.12

mhaseeb123 avatar Jul 18 '24 23:07 mhaseeb123

All of these classes already have constructors. I think what you mean is we should remove the factory functions.

harrism avatar Jul 22 '24 10:07 harrism

I opened two PRs, #1625 and #1626, that should help with this.

bdice avatar Jul 23 '24 21:07 bdice

Added tasklist to this issue.

harrism avatar Jul 23 '24 23:07 harrism