raft icon indicating copy to clipboard operation
raft copied to clipboard

WIP: update fmt (>=10.2.1) and spdlog (>=1.13)

Open jameslamb opened this issue 1 year ago • 1 comments

Description

Contributes to:

  • https://github.com/rapidsai/build-planning/issues/54
  • https://github.com/rapidsai/build-planning/issues/56
  • https://github.com/rapidsai/rapids-cmake/issues/387

Testing with:

  • https://github.com/rapidsai/rapids-cmake/pull/592
  • https://github.com/rapidsai/rmm/pull/1544

Notes for Reviewers

Will put up a better description and revert testing-only changes before marking this ready for review.

Testing with an approach similar to https://github.com/rapidsai/cuml/pull/5640

jameslamb avatar Apr 25 '24 20:04 jameslamb

The CUDA 12.x conda-python-tests jobs are failing here, like this:

ImportError while importing test module '/__w/raft/raft/python/pylibraft/pylibraft/test/test_brute_force.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/conda/envs/test/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
test/test_brute_force.py:21: in <module>
    from pylibraft.neighbors.brute_force import knn
/opt/conda/envs/test/lib/python3.11/site-packages/pylibraft/neighbors/__init__.py:16: in <module>
    from pylibraft.neighbors import brute_force  # type: ignore
E   ImportError: libnvJitLink.so.12: cannot open shared object file: No such file or directory

(build link)

That looks unrelated to these changes. I see the same issues on other recent PRs:

jameslamb avatar Apr 29 '24 14:04 jameslamb

This work is paused, in favor of pursuing a better long-term solution in the future. Closing this PR for now.

Subscribe to https://github.com/rapidsai/build-planning/issues/54 and https://github.com/rapidsai/build-planning/issues/56 for updates.

jameslamb avatar Jul 18 '24 16:07 jameslamb