integration icon indicating copy to clipboard operation
integration copied to clipboard

Remove numba dependency

Open gmarkall opened this issue 1 year ago • 4 comments

EDIT: This now removes the numba dependency, which comes transitively from cuDF.

Original description:

numba-cuda is the NVIDIA-maintained CUDA target for Numba, which depends on the numba package.

This PR replaces the numba dependency with numba-cuda. However, similar to @bdice's comment in #648, I don't know if we strictly need this here any more due to the cudf dependency (from rapidsai/cudf#16474) ensuring numba-cuda is present.

gmarkall avatar Aug 02 '24 11:08 gmarkall

I think we can delete the dependencies that come transitively from RAPIDS repositories. Let’s remove the numba pins here.

bdice avatar Aug 03 '24 01:08 bdice

@bdice Many thanks for the suggestion - I think I've implemented it as you suggested (and updated the title / description)

gmarkall avatar Aug 05 '24 10:08 gmarkall

@gmarkall I think this might be ready to merge if you agree. I merged the upstream since CI was failing.

bdice avatar Aug 29 '24 17:08 bdice

@bdice I think this should be fine as the dependency comes from cudf (and will come from its numba-cuda dependency once https://github.com/rapidsai/cudf/pull/16474 is merged).

gmarkall avatar Aug 30 '24 08:08 gmarkall

I updated this PR and retargeted to 24.12. I will give it a /merge so it can move forward if CI passes.

bdice avatar Oct 22 '24 00:10 bdice

/merge

bdice avatar Oct 22 '24 00:10 bdice