cuvs icon indicating copy to clipboard operation
cuvs copied to clipboard

Moving random ball cover

Open cjnolet opened this issue 1 year ago • 6 comments

cjnolet avatar Jul 11 '24 19:07 cjnolet

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.49%. Comparing base (05494cb) to head (0e9323f). Report is 4 commits behind head on branch-25.06.

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-25.06     #218   +/-   ##
=============================================
  Coverage         84.49%   84.49%           
=============================================
  Files                20       20           
  Lines               129      129           
=============================================
  Hits                109      109           
  Misses               20       20           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Jul 12 '24 00:07 codecov-commenter

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Linking https://github.com/rapidsai/cuvs/issues/110

cjnolet avatar Jul 30 '24 23:07 cjnolet

/ok to test

cjnolet avatar Aug 27 '24 00:08 cjnolet

/ok to test

cjnolet avatar Aug 28 '24 18:08 cjnolet

Metrics are showing this change adds ~78mb to the overall binary size. This is not acceptable.

Screenshot from 2024-08-29 12-45-14

cjnolet avatar Aug 29 '24 16:08 cjnolet

As of commit https://github.com/rapidsai/cuvs/pull/218/commits/854837c5c616893810143c71c272324e5f47de3f, the total size added is now ~19 MB, while the wheel size increases from ~900 MB to ~911 MB.

Screenshot 2025-05-07 at 5 39 41 PM

divyegala avatar May 07 '25 23:05 divyegala

/merge

divyegala avatar May 09 '25 20:05 divyegala