cudf
cudf copied to clipboard
rapidsai
Update patches for CCCL 2.6
This adopts the patches to thrust to apply with CCCL 2.6.
Should only be merged when updating the CCCL version, but I am opening them now to not forget it and then accidentally drop them
Better yet would be to just nuke these patches. I believe we can do that once these two CCCL issues are done:
- https://github.com/NVIDIA/cccl/issues/1958 (obviates the need for the index type patch)
- https://github.com/NVIDIA/cccl/pull/2154 (obviates the need for the radix sort patch)
It looks like both of the above are merged now (https://github.com/NVIDIA/cccl/pull/2154 just merged yesterday) so in principle we should be able to drop these patches if we upgrade straight to CCCL>=2.6.2.
@jrhemstad @vyasr We have three patches, and I see two fixes. I see how the CCCL offset-dispatch changes will fix thrust_disable_64bit_dispatching.diff and ChainedPolicy changes will fix thrust_faster_scan_compile_times.diff.
I don't see a solution for the #pragma unroll 1 in thrust_faster_sort_compile_times.diff yet. Is that correct? Am I missing something?
It'd be nice to update CCCL and drop all patches at once, but it'd be okay to get rid of two if we aren't able to solve the third one in the near term.
That's a good question. I didn't investigate and was just responding to the comments. If we have to keep one patch around that's not the end of the world, although if that's the case given that the other bits were resolved upstream we should open a CCCL issue requesting the change to sort as well.
