cudf
cudf copied to clipboard
rapidsai
Move tpch examples into benchmarks
Description
Moving the TPC-H examples into benchmarks with the goal of converting each of them into NVBench's. This PR would not do that and would be done in a separate PR.
Checklist
- [x] I am familiar with the Contributing Guidelines.
- [x] New or existing tests cover these changes.
- [x] The documentation is up to date with these changes.
@davidwendt @PointKernel Would you please review this changeset from Jayjeet?
Should we migrate at least one example or benchmark to NVBench in this PR to ensure that the build system and data generation work correctly in the new setup? Doing this now will make the follow-up PRs more straightforward.
Hi @PointKernel , The datagen PR #16294 is yet to be merged. So, we can't integrate the examples/benchmarks with the datagen yet. But, I can convert these to NVBenches regardless, but they would need local files to exist for now.
Hi @PointKernel , So, I will have to hardcode the dataset dir for my dev env for me to convert these to nvbenches now, which I don't think is a good idea. Can we just merge it without NVbench for now ?
The datagen PR #16294 is yet to be merged. So, we can't integrate the examples/benchmarks with the datagen yet.
I could miss something obvious but can we can wait for #16294 to be merged first and then focus on NVbench migration in this PR? Moving existing code and outdated documentation to a new location without making actual changes can easily lead to overlooked details.
I could miss something obvious but can we can wait for https://github.com/rapidsai/cudf/pull/16294 to be merged first and then focus on NVbench migration in this PR? Moving existing code and outdated documentation to a new location without making actual changes can easily lead to overlooked details.
Sounds good ! Let's wait for #16294
@JayjeetAtGithub to unblock yourself, you may work on with changes from https://github.com/rapidsai/cudf/pull/16294 in a new branch and create a PR, mention that #16294 and #16663 are dependent PRs in description.
I noted this offline -- let's try to write "NDS-H" anywhere it appears in text, rather than "NDSH."
