cudf icon indicating copy to clipboard operation
cudf copied to clipboard

Published 20 hours ago • verified publisher icon rapidsai

Backport #16045 to 24.06

Open vyasr opened this issue 1 year ago • 3 comments

Description

Backporting for a patch release.

Checklist

  • [ ] I am familiar with the Contributing Guidelines.
  • [ ] New or existing tests cover these changes.
  • [ ] The documentation is up to date with these changes.

vyasr avatar Jun 26 '24 17:06 vyasr

Was there supposed to be a code fix here? This looks like we are just backporting new unit test.

Perhaps this was for a cuco change. I'm not sure backporting a unit test is necessary. Are we concerned that possible future patches will break?

davidwendt avatar Jun 26 '24 17:06 davidwendt

The fix is in #16101, you're right that this is just a test for that behavior. I'd be fine skipping the test and only backporting the actual fix. CC @bdice.

vyasr avatar Jun 26 '24 18:06 vyasr

I favor backporting the test since it was missed in the original PR and provides a way to verify that the backported fix actually works in 24.06 (it was only tested in 24.08). I don’t have any specific concerns that it will fail, it is moreso a matter of completeness in addressing the reported bug in an easily verifiable way.

bdice avatar Jun 26 '24 21:06 bdice