cudf icon indicating copy to clipboard operation
cudf copied to clipboard

Fix ArrowDeviceArray interface to pass address of event

Open zeroshade opened this issue 1 year ago • 5 comments

Description

the sync_event member of ArrowDeviceArray needs to be a pointer to a cudaEvent_t, currently we're returning the cudaEvent_t directly. We need to be passing the address of the event. Thankfully this is a single line change, plus adding a test to confirm.

Checklist

  • [x] I am familiar with the Contributing Guidelines.
  • [x] New or existing tests cover these changes.
  • [x] The documentation is up to date with these changes.

zeroshade avatar Jun 18 '24 20:06 zeroshade

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

copy-pr-bot[bot] avatar Jun 18 '24 20:06 copy-pr-bot[bot]

CC @vyasr

zeroshade avatar Jun 18 '24 20:06 zeroshade

/ok to test

davidwendt avatar Jun 24 '24 15:06 davidwendt

Added calls to cudaEventSynchronize

zeroshade avatar Jun 28 '24 20:06 zeroshade

/ok to test

vyasr avatar Jun 28 '24 22:06 vyasr

@vyasr anything else needed for this to get merged?

zeroshade avatar Jul 03 '24 20:07 zeroshade

/merge

davidwendt avatar Jul 11 '24 23:07 davidwendt