cudf icon indicating copy to clipboard operation
cudf copied to clipboard

Allow anonymous user in devcontainer name.

Open bdice opened this issue 1 year ago • 1 comments

Description

In https://github.com/rapidsai/cudf/pull/15572, we updated the devcontainer name to include the current user's name. However, in GitHub Codespaces, the username is not defined. As a result, the container name starts with a dash. This is not allowed by GitHub Codespaces, so it fails to launch.

This PR adds a default value of anon to the devcontainer username.

Checklist

  • [x] I am familiar with the Contributing Guidelines.
  • [x] New or existing tests cover these changes.
  • [x] The documentation is up to date with these changes.

bdice avatar May 20 '24 13:05 bdice

Can we rapids-reviser this (or at least create an issue)? I assume it affects all RAPIDS repos.

vyasr avatar May 20 '24 21:05 vyasr

Can we rapids-reviser this (or at least create an issue)? I assume it affects all RAPIDS repos.

I applied this fix across repos. The new PRs link to this one.

  • https://github.com/rapidsai/cugraph-ops/pull/654
  • https://github.com/rapidsai/cuspatial/pull/1396
  • https://github.com/rapidsai/raft/pull/2355
  • https://github.com/rapidsai/rmm/pull/1576

bdice avatar Jun 06 '24 23:06 bdice

/merge

bdice avatar Jun 06 '24 23:06 bdice

Can we rapids-reviser this (or at least create an issue)? I assume it affects all RAPIDS repos.

I applied this fix across repos. The new PRs link to this one.

* [Allow anonymous user in devcontainer name cugraph-ops#654](https://github.com/rapidsai/cugraph-ops/pull/654)

* [Allow anonymous user in devcontainer name cuspatial#1396](https://github.com/rapidsai/cuspatial/pull/1396)

* [Allow anonymous user in devcontainer name raft#2355](https://github.com/rapidsai/raft/pull/2355)

* [Allow anonymous user in devcontainer name rmm#1576](https://github.com/rapidsai/rmm/pull/1576)

Thanks!

vyasr avatar Jun 07 '24 01:06 vyasr