cudf icon indicating copy to clipboard operation
cudf copied to clipboard

Use rapids-build-backend.

Open vyasr opened this issue 1 year ago • 3 comments

Description

This PR uses rapids-build-backend to simplify wheel builds and reduce the complexity of various CI/build scripts.

See also:

  • https://github.com/rapidsai/rapids-build-backend
  • https://github.com/rapidsai/build-planning/issues/31

Checklist

  • [x] I am familiar with the Contributing Guidelines.
  • [x] New or existing tests cover these changes.
  • [x] The documentation is up to date with these changes.

vyasr avatar Mar 06 '24 23:03 vyasr

Like we talked about offline, I'm gonna take this one over. I just merged that latest branch-24.06 into this, and I'll start pushing stuff here based on what I've learned doing this for rmm over in https://github.com/rapidsai/rmm/pull/1502.

Planning to start with just wheels and then build from there... that's why right now so many of the CI checks are commented out on this branch.

jameslamb avatar May 08 '24 22:05 jameslamb

I notice you added a version test for every package except cudf_kafka, any reason for that? If not, maybe should add that one too.

I didn't add one there because I don't see any other cudf_kafka tests, and I didn't want to grow the PR too much by also introducing a test setup for it (a tests/ directory and CI job).

Do you want me to add that here?

I'll write up an issue here for that either way... I think it'd be generally useful to have something in CI running import cudf_kafka after installing from a cudf-kafka wheel.

jameslamb avatar May 23 '24 16:05 jameslamb

I added an issue about setting up cudf_kafka tests: https://github.com/rapidsai/cudf/issues/15841

jameslamb avatar May 23 '24 17:05 jameslamb

Oh yeah never mind I forgot that kafka was just untested. Ignore that for this PR.

vyasr avatar May 23 '24 23:05 vyasr

Alright I think this one's ready for review (no rush!).

I've updated it with all the things we talked about on https://github.com/rapidsai/rmm/pull/1502 and https://github.com/rapidsai/cuml/pull/5804, and it's using the latest version of rapids-build-backend.

jameslamb avatar May 24 '24 22:05 jameslamb

/merge

jameslamb avatar May 29 '24 22:05 jameslamb