cudf icon indicating copy to clipboard operation
cudf copied to clipboard

Default to equal NaNs in make_collect_set_aggregation.

Open bdice opened this issue 3 years ago • 2 comments

Description

Resolves #11329. This aligns our default behaviors for null and NaN equality across APIs. After this change, all functions should default to treating null values as equal to one another and NaN values as equal to one another.

Checklist

  • [x] I am familiar with the Contributing Guidelines.
  • [ ] New or existing tests cover these changes.
  • [ ] The documentation is up to date with these changes.

bdice avatar Aug 29 '22 19:08 bdice

rerun tests

bdice avatar Aug 29 '22 22:08 bdice

rerun tests

bdice avatar Sep 09 '22 15:09 bdice

Codecov Report

Base: 87.40% // Head: 88.13% // Increases project coverage by +0.72% :tada:

Coverage data is based on head (643d02f) compared to base (f72c4ce). Patch coverage: 89.92% of modified lines in pull request are covered.

:exclamation: Current head 643d02f differs from pull request most recent head 3411708. Consider uploading reports for the commit 3411708 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11621      +/-   ##
================================================
+ Coverage         87.40%   88.13%   +0.72%     
================================================
  Files               133      133              
  Lines             21833    21987     +154     
================================================
+ Hits              19084    19379     +295     
+ Misses             2749     2608     -141     
Impacted Files Coverage Δ
python/cudf/cudf/core/dataframe.py 93.77% <ø> (ø)
python/cudf/cudf/core/indexed_frame.py 92.03% <ø> (ø)
python/cudf/cudf/core/udf/__init__.py 97.05% <ø> (+47.05%) :arrow_up:
python/cudf/cudf/io/orc.py 92.94% <ø> (-0.09%) :arrow_down:
python/cudf/cudf/testing/dataset_generator.py 72.83% <ø> (-0.42%) :arrow_down:
...thon/dask_cudf/dask_cudf/tests/test_distributed.py 18.86% <ø> (+4.94%) :arrow_up:
python/cudf/cudf/core/_base_index.py 82.20% <43.75%> (-3.35%) :arrow_down:
python/cudf/cudf/io/text.py 91.66% <66.66%> (-8.34%) :arrow_down:
python/strings_udf/strings_udf/__init__.py 84.31% <76.00%> (-12.57%) :arrow_down:
python/dask_cudf/dask_cudf/backends.py 84.90% <82.92%> (-0.37%) :arrow_down:
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 20 '22 16:10 codecov[bot]

@gpucibot merge

bdice avatar Oct 20 '22 22:10 bdice