cudf icon indicating copy to clipboard operation
cudf copied to clipboard

Determine if Arrow has S3 support at runtime in unit test.

Open bdice opened this issue 3 years ago • 2 comments

Description

Resolves #11559. Opening a draft for now, to let CI test things out.

TODO:

  • [ ] Needs manually tested for the case where Arrow doesn't have S3 support.

Checklist

  • [x] I am familiar with the Contributing Guidelines.
  • [ ] New or existing tests cover these changes.
  • [x] The documentation is up to date with these changes.

bdice avatar Aug 17 '22 22:08 bdice

Codecov Report

Base: 88.11% // Head: 88.14% // Increases project coverage by +0.03% :tada:

Coverage data is based on head (ce10aae) compared to base (5c2150e). Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11560      +/-   ##
================================================
+ Coverage         88.11%   88.14%   +0.03%     
================================================
  Files               133      133              
  Lines             21982    21982              
================================================
+ Hits              19369    19376       +7     
+ Misses             2613     2606       -7     
Impacted Files Coverage Δ
python/cudf/cudf/core/dataframe.py 93.77% <0.00%> (+0.04%) :arrow_up:
python/cudf/cudf/core/column/string.py 88.65% <0.00%> (+0.12%) :arrow_up:
python/cudf/cudf/core/groupby/groupby.py 91.51% <0.00%> (+0.20%) :arrow_up:
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) :arrow_up:
python/cudf/cudf/core/column/lists.py 93.75% <0.00%> (+0.96%) :arrow_up:
python/strings_udf/strings_udf/__init__.py 86.27% <0.00%> (+1.96%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Aug 18 '22 00:08 codecov[bot]

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

github-actions[bot] avatar Sep 17 '22 22:09 github-actions[bot]

LGTM! Does the CI setup test both configurations? Otherwise we might miss the failure detection breaking silently

No, we don't have a way to test the configuration with S3 disabled in CI. We would have to make significant changes to how dependencies are installed in CI. It might be possible once CI is more configurable via a GitHub Actions matrix build, but I don't think the benefit is worth the cost here.

bdice avatar Oct 26 '22 18:10 bdice

@gpucibot merge

bdice avatar Oct 26 '22 18:10 bdice