cudf icon indicating copy to clipboard operation
cudf copied to clipboard

Adding feature Truncate to DataFrame and Series

Open VamsiTallam95 opened this issue 3 years ago • 1 comments

Description

This PR closes #9629 by adding truncate feature to DataFrame and Series. Truncates a DataFrame or Series before and after some index value. If the index being truncated contains only datetime values, before and after may be specified as strings instead of Timestamps.

Checklist

  • [x] I am familiar with the Contributing Guidelines.
  • [x] New or existing tests cover these changes.
  • [x] The documentation is up to date with these changes.

VamsiTallam95 avatar Aug 02 '22 17:08 VamsiTallam95

In addition to the great suggestions from @bdice , could we add truncate to the relevant rst's so they show up in the docs? Thanks again and great work :)

brandon-b-miller avatar Aug 03 '22 12:08 brandon-b-miller

Codecov Report

Base: 87.47% // Head: 88.11% // Increases project coverage by +0.63% :tada:

Coverage data is based on head (9127a42) compared to base (f817d96). Patch has no changes to coverable lines.

:exclamation: Current head 9127a42 differs from pull request most recent head b3bea25. Consider uploading reports for the commit b3bea25 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11435      +/-   ##
================================================
+ Coverage         87.47%   88.11%   +0.63%     
================================================
  Files               133      135       +2     
  Lines             21826    22021     +195     
================================================
+ Hits              19093    19404     +311     
+ Misses             2733     2617     -116     
Impacted Files Coverage Δ
python/cudf/cudf/io/text.py 91.66% <0.00%> (-8.34%) :arrow_down:
python/strings_udf/strings_udf/__init__.py 76.47% <0.00%> (-7.85%) :arrow_down:
python/cudf/cudf/core/_base_index.py 81.28% <0.00%> (-4.27%) :arrow_down:
python/cudf/cudf/io/json.py 92.06% <0.00%> (-2.68%) :arrow_down:
python/cudf/cudf/utils/utils.py 89.91% <0.00%> (-0.69%) :arrow_down:
python/dask_cudf/dask_cudf/core.py 73.72% <0.00%> (-0.41%) :arrow_down:
python/cudf/cudf/io/parquet.py 90.45% <0.00%> (-0.39%) :arrow_down:
python/dask_cudf/dask_cudf/backends.py 84.90% <0.00%> (-0.37%) :arrow_down:
python/cudf/cudf/core/column/datetime.py 89.62% <0.00%> (-0.09%) :arrow_down:
python/cudf/cudf/io/orc.py 92.94% <0.00%> (-0.09%) :arrow_down:
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Aug 17 '22 21:08 codecov[bot]

rerun tests

VamsiTallam95 avatar Aug 18 '22 21:08 VamsiTallam95

rerun tests

VamsiTallam95 avatar Aug 19 '22 16:08 VamsiTallam95

@bdice apologies, it looked like @VamsiTallam95 was just waiting on reviews to continue. It looks like he is currently blocked, though?

vyasr avatar Sep 01 '22 19:09 vyasr

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

github-actions[bot] avatar Oct 01 '22 21:10 github-actions[bot]

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

GPUtester avatar Nov 04 '22 18:11 GPUtester

ok to test

Whoops I don't think I can do that, will request.

vyasr avatar Nov 04 '22 18:11 vyasr

ok to test

bdice avatar Nov 04 '22 19:11 bdice

@gpucibot merge

vyasr avatar Nov 04 '22 23:11 vyasr