budget icon indicating copy to clipboard operation
budget copied to clipboard

Use relative path for redirect

Open nextlogic-ono opened this issue 5 years ago • 2 comments
trafficstars

When I access the root path as https://my-budget-domain/ having nginx proxy in front of it, it redirects to http://my-budget-domain/dashboard as an absolute URL but it should be given a relative path of /dashboard for Location header as when I embed the app inside a https iframe, the content gets blocked as it tries to access http inside https during redirection.

It seems this happens on other links as well such as /settings for the Settings link in the menu.

nextlogic-ono avatar Sep 28 '20 07:09 nextlogic-ono

There's also a http link for resending verification email but this can be a relative path too.

budget-http-form

nextlogic-ono avatar Sep 28 '20 08:09 nextlogic-ono

I'm currently looking into this, however it looks like we're using Laravel's "recommended" way of redirecting (at least in IndexController), which is through named routes.

I'm afraid I can't do anything about the way that the framework works. If you think there's a sensible solution I'd love to hear about it 🙂

range-of-motion avatar Dec 03 '20 17:12 range-of-motion

I'm revisiting this.

I can make the paths relative by passing a 3rd argument to route() helper. If you still need this, please let me know and I'll re-open this.

range-of-motion avatar Apr 02 '23 20:04 range-of-motion