Hetzner node template support PlacementGroup, Firewalls, AdditionalKeys, ImageID

[process0]

This PR provides improved support for the Hetzner Node Template resource by adding:

• The ability to set the node image id via image_id (resolves https://github.com/rancher/terraform-provider-rancher2/issues/751)
• The ability to set node ssh keys via additional_keys (resolves https://github.com/rancher/terraform-provider-rancher2/issues/654)
• The ability to set the node placement group via placement_group
• The ability to set the node firewalls via firewalls (resolves https://github.com/rancher/terraform-provider-rancher2/issues/865)

The existing firewalls PR (https://github.com/rancher/terraform-provider-rancher2/pull/866) expects a comma separated string for the list values, whereas this PR allows them to be specified in a list (like other multi-valued fields are specified in other driver configs e.g. AWS EC2, Azure, vSphere). It would make sense that the other two fields for this config (networks and volumes) would be made into string lists, but I have opted to not include this as it would break backward compatibility.

I've opened an issue for that here: https://github.com/rancher/terraform-provider-rancher2/issues/893

[stefandanaita]

It would be amazing if this made it into the next release!

[leonsteinhaeuser]

@process0 I just closed PR #866 so the Rancher team can focus on this PR.

I would like to see this patch in one of the next releases. So far, I've had to adjust our workflows quite a bit to get it to work.

[process0]

@leonsteinhaeuser What were the adjustments you had to make to get this to work beyond updating comma separated strings? If the proposed changes aren't sensible, I can revise the PR.

[leonsteinhaeuser]

The customizations were more about our automation and the way we deploy this extension. At the beginning, we decided to clone your fork and install it as a dev plugin. After a few uses, we discovered a few issues with this solution, so we decided to fork, build and release a customized plugin: https://github.com/programmfabrik/terraform-provider-rancher2

[KittlitzMichael]

Hello dear Rancher2-Team,

please Merge this Issue soon, we need this functionality urgend! Thank you!

Best Regards

Michael

[KittlitzMichael]

@annablender -> could you approve please ?

[audriusb]

anyone? please?

[stefandanaita]

Many months later this is still not being looked at 😢

[KittlitzMichael]

Many months later this is still not being looked at 😢

Yeah. It's stall. I wonder if we should tell Hetzner.de as it should be in their own intrests to have this working or if one knows who to contact at Suse (maybe both ways would be helpful).

[leonsteinhaeuser]

@bashofmann, @annablender, @jakefhyde can any of you take a look at the PR and give us feedback or merge it so we can finally use it in productions? I am probably not the only one who has been waiting for this change for a very long time.

[process0]

I'll get around to fixing the PR this weekend. It will require retesting to verify these changes still work, and to confirm the reasoning of why I set image_id default to 0 (iirc default 0 signified the default image hetzner uses, but its been a while)

[mwoelk]

Because it seems that this PR has gone stale I took the liberty of changing the requested things: #1162

[kkaempf]

closing stale PRs. If you still intend to work on this, please reopen.

[KittlitzMichael]

Please merge this features, instead of just closing the PR.