local-path-provisioner icon indicating copy to clipboard operation
local-path-provisioner copied to clipboard

Allow parameters block for StorageClass

Open mdfaizsiddiqui opened this issue 2 years ago • 5 comments

Documentation around parameters block for storageClass - https://kubernetes.io/docs/concepts/storage/storage-classes/#parameters

For our use-case we wanted the volume to be of xfs file system and we were able to achieve it with this block -

parameters:
  fsType: xfs

So, I am adding a way in helm chart to specify parameters block for the storageClass.

mdfaizsiddiqui avatar Aug 16 '23 22:08 mdfaizsiddiqui

@mdfaizsiddiqui local-path-provisioner actually creates a directory on a local filesystem (it can be xfs, ext4 and so one), so the fsType seems not really used. Can you elaborate more on the fsType? Thank you.

derekbit avatar Oct 27 '23 02:10 derekbit

this is also useful if you want to achieve other things, like eg. limiting default storageClass to some nodePath:

parameters:
  nodePath: /srv/k8s/pv/default

JuniorJPDJ avatar Apr 12 '24 20:04 JuniorJPDJ

@mdfaizsiddiqui Can you help resolve the conflicts? Thank you.

derekbit avatar May 27 '24 00:05 derekbit

@mdfaizsiddiqui Can you help resolve the conflicts? Thank you.

Hey, I've fixed all the conflicts, but due to this new change I had to move the parameter introduced as part of @AlbanBedel PR to the new parameters section.

mdfaizsiddiqui avatar May 27 '24 12:05 mdfaizsiddiqui

@derekbit can you help merge this PR, thanks.

mdfaizsiddiqui avatar May 29 '24 14:05 mdfaizsiddiqui

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Jul 29 '24 02:07 github-actions[bot]

This PR was closed because it has been stalled for 10 days with no activity.

github-actions[bot] avatar Aug 09 '24 02:08 github-actions[bot]