rspotify icon indicating copy to clipboard operation
rspotify copied to clipboard

Yank version 0.11.7 from crates.io

Open ThomasFrans opened this issue 2 years ago • 2 comments

Describe the bug There seemed to have been a breaking change in one of the playlist methods (use of duration instead of an integer) which made its way onto crates.io. Some people are experiencing issues when installing other programs using that version. I wonder whether it would make sense to yank it as that would prevent these issues. It would still allow crates that are already using it to keep using the yanked version, but would prevent further confusion.

Expected behavior Minor version increases should not have breaking API changes. A new version could be published with a major version increase (which is recommended by the semantic versioning standard when there is an unexpected breaking change). I think the breaking change has already been resolved so this major version increase wouldn't be needed.

Additional Context I hope it's OK to suggest this. It's not fun to yank a release, but since it can cause confusion and is already confusing some people when they use cargo install without adding --locked, it would make sense to prevent this. :slightly_smiling_face:

ThomasFrans avatar Jun 06 '23 22:06 ThomasFrans

Hi Thomas, thanks for your suggestion, I think your point makes sense and reasonable, this library introduces some breaking API changes, so it shouldn't be a minor version increase, and it also introduces a fatal problem with the playlist method, so the v0.11.7 should be yanked from crates.io.

But I think a better solution is releasing a new version like v0.12 before yanking the v0.11.7 version, so other developers are able to upgrade to the latest version.

I would like to publish a new version after merging these two PRs:

  • https://github.com/ramsayleung/rspotify/pull/424
  • https://github.com/ramsayleung/rspotify/pull/418

ramsayleung avatar Jun 07 '23 17:06 ramsayleung

Message to comment on stale issues. If none provided, will not mark issues stale

github-actions[bot] avatar Dec 05 '23 02:12 github-actions[bot]

Closing this issue since the v0.11.7 has been yanked.

ramsayleung avatar Mar 12 '24 04:03 ramsayleung