VaultSharp icon indicating copy to clipboard operation
VaultSharp copied to clipboard

Published 20 hours ago • verified publisher icon rajanadar

Support for ldap secret engine, static and dynamic roles

Open protonyx opened this issue 2 years ago • 3 comments

Fixes a type mismatch bug with the existing LDAP secret engine implementation. Adds full support for static and dynamic roles in the LDAP secret engine.

Vault API Docs: https://developer.hashicorp.com/vault/api-docs/v1.13.x/secret/ldap

protonyx avatar Nov 14 '23 00:11 protonyx

I agree with all suggestions, though I was following the conventions in the database secret engine so it might be worth revisiting as well.

I also noticed that the LDAP secret engine is referenced as OpenLDAP in the code, which no longer aligns with the Hashicorp documentation. Should that be modified as well?

protonyx avatar Nov 19 '23 21:11 protonyx

I also noticed that the LDAP secret engine is referenced as OpenLDAP in the code, which no longer aligns with the Hashicorp documentation. Should that be modified as well?

Hey, I guess we must not, since it would affect backward compatibility. We need to check with @rajanadar on this. The process is to mark it as a breaking change, but I'm not sure whether it will go in a patch or a major release.

konidev20 avatar Nov 20 '23 05:11 konidev20

Any additional feedback for this PR?

protonyx avatar Dec 17 '23 00:12 protonyx