npm-check-updates icon indicating copy to clipboard operation
npm-check-updates copied to clipboard

Make --format group,repo the default

Open wmertens opened this issue 1 year ago • 3 comments
trafficstars

  • [x] I have searched for similar issues
  • [x] I am using the latest version of npm-check-updates
  • [x] I am using node >= 14.14

IMHO it's much more user friendly to show repo links and group by update type by default.

wmertens avatar Mar 15 '24 06:03 wmertens

Thank you for the suggestion. I've thought about making --format group the default as I tend to prefer it in all cases.

--format repo reads all the dependencies' package files from disk which has some performance overhead, so it needs to remain opt-in.

raineorshine avatar Mar 15 '24 15:03 raineorshine

reads all the dependencies' package files from disk which has some performance overhead

It's not doing a directory traversal, it's just loading specific package.json files at known paths when needed. Worst case it'll check 3 paths for every package which got updated and load at most one JSON file.

Given that this package does a lot of fetching over the internet, reading some files off of disk seems pretty fast in comparison I'm not sure it's noticeable.


TLDR: I think it's a good default. :)

CreativeTechGuy avatar Mar 21 '24 06:03 CreativeTechGuy

Yeah, you're probably right. And zero overhead if we can parallelize it.

I'm still leaning towards opt-in --format repo for aesthetic reasons. (I wish we could do <a href="">...</a> in the terminal.)

--format group is definitely better than the current default though.

raineorshine avatar Mar 21 '24 14:03 raineorshine