jbuilder icon indicating copy to clipboard operation
jbuilder copied to clipboard

Namespacing directory generation fix

Open nullset2 opened this issue 8 years ago • 3 comments

See issue #379. Very quick contribution, the tests pass afaik, I used gsub on the templates because using that we'll avoid breaking the templates for un-namespaced scaffolding. I know there's probably a better way to do this but I think this is still usable though.

nullset2 avatar Feb 06 '17 02:02 nullset2

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rwz (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

rails-bot avatar Feb 06 '17 02:02 rails-bot

Hey guys, sorry about dropping off this PR a while ago, I got stuck with a lot of stuff and I'm trying to pick it up now.

The checks pass now and I think I have described the problem adequately and my approach works, however I'm willing to change stuff if you have feedback for me.

Thanks dudes.

nullset2 avatar Apr 19 '17 22:04 nullset2

@rafaelfranca do you have any additional input for this?

nullset2 avatar Jul 09 '17 20:07 nullset2