Rafael Schouten

Results 1042 comments of Rafael Schouten
trafficstars

So its allocating on 1.3 but not 1.6? You can put that test in a version specific conditional, or we can stop supporting 1.3

Ok I'll try to have a look tonight.

Normally we would resolve those two open questions first? One is performance and the other is syntax, which would mean a second breaking change if we change that later.

The performance issue will take 5 minutes to fix... But the general idea is I wouldn't ask that question in a review if I didn't want to discuss it before...

Just use `map` instead of a loop and the mixed type tuple should be type stable

That's a fold.... `foldl` should also be type stable - if you use `StaticModel`

Ah right, maybe we should remove it instead.

Also how is the ttfx for this stuff? Seems that type stability and allocations from it might also take a while to compile.

Yeah... the type stability is probably more important for that than for runtime speed. Have a look with `@snoopi_deep` and Cthulhu.jl, there might be some easy wins.

I don't know that much about CLIMA, I just use it as an example of the kind of models this is designed for - complex physical/environmental models that have heirarchical...