Rafael Schouten
Rafael Schouten
Probably `CoordLookupArray` needs a `show` method. See the defaults in LookupArrays/show.jl
Yeah, it doesnt yet know the order or if the lookup is ordered at all. You can (fully) specify the `Categorical` lookup manually and it should be type stable.
Yes its fine if you specify `Categorical` with the `order` keyword: ```julia using DimensionalData.LookupArrays bar(x, y) = cat(x, y; dims=Dim{:foo}(Categorical([:c, :d]; order=ForwardOrdered()))) julia> @inferred bar(da, da) 3×2 DimArray{Float64,2} with dimensions:...
Making `cat` type stable when allowing it to still work on runtime-validated incorrect dims is pretty hard. Maybe we need to separate out method dispatch for this specific case so...
Its not forward ordered tho, so searchsorted wont work. Probably set should error
Maybe we need to let you set both in the same call so there is never an incorrect state. The problem with auto-detecting the order in `set` is it would...
Yeah that's how it works, you can only add to function defined somewhere else, you can't "see" functions or types created inside the extension. Returning an interpolator is probably a...
Sorry was too busy with other things. The Project.toml file is broken, you need an equals sign for the Interpolations version here: https://github.com/rafaqz/DimensionalData.jl/actions/runs/7786303160/job/21230819886#step:4:46
Just realised this PR was against the other PR, so I'll reopen it
I guess we can just duplicate these tests? https://github.com/mcabbott/AxisKeys.jl/blob/master/test/_chainrules.jl I dont understand differentiation or its package ecosystem like invenia people do, but I *can* copy their code 😅