Rafael Schouten
Rafael Schouten
Seconding the bump on this, a Dictionary with `getproperty` on keys would be perfect for seamless switching between `Dictionary` and `NamedTuple` for runtime/compilation tradeoffs, e.g. in DimensionalData.jl `DimStack`.
I didnt mention here but after the later fix to Parsers.jl (removing just 4 `@inline`s 😂) this PR stopped doing much: https://github.com/JuliaData/Parsers.jl/pull/1140 All the `@noinlines` and function barriers were effective...
Another example of this: https://github.com/rafaqz/DimensionalData.jl/issues/464#issuecomment-1437217274 Loading OffsetArrays.jl "fixes" a bug in `Base.stack` with DimensionalData.jl. And critically, we test against OffsetArrays.jl, as `AbstractArray` extending packages should do. **But this will hide...
I'm not sure `AbstractOneTo` would solve this problem. The `similar` method in question can't be extended practically without type piracy, that only OffsetArrays.jl can do. See: https://github.com/JuliaLang/julia/issues/48736#issuecomment-1437414217
So this is a problem with the GeometryBasics.jl `convert` method. https://github.com/JuliaGeometry/GeometryBasics.jl/blob/db65c41fd75f478b4079d8f4825784f307af024d/src/geointerface.jl#L90 Needs to be changed to: `LineString(Point{dim, Float64}[Point{dim, Float64}(GeoInterface.coordinates(p)) for p in getgeom(geom)])` So the vector type is set even...
I looked into this: we need to think about what to do with empty geometries in `getgeom`. It's currently not clear what to return as we don't know the eltype....
Yeah, there are a lot of issues with zero length polygons and other geometries. Base julia uses some dark arts like return value inference to make zero length iterators make...
Ok so what you want isn't possible in Makie unless we do that NaN point hack. @SimonDanisch any ideas here? should Makie be able to plot zero length polygons?
@mbauman the docs still says `AbstractArray` of scalar indices even for known friendly types ;) But absolutely, limiting it as `to_indices(A::StaticArray, ...` would fix the problem.
Totally, there are some problems with unorthodox indexing like this in DimensionalData.jl, because it relies on `searchsorted*` so much. The problem is there is no entirely type-stable way to handle...