Rafael Schouten

Results 1515 comments of Rafael Schouten

Yeah isnt the circular thing a problem for CI? Like how can tests pass for one without the other when you bump compat?

This is already tested as working. But yes we also need to handle features somehow. I guess I should have handle that in GeoInterface as well.

Looks like a DiskArrays.jl problem to me (otherwise you couldn't use `filter` at all) The problem is actually that `map` doesn't reorder itself so the bitmatrix is wrong: ```julia julia>...

So this is a DiskArrays.jl issue

Haha this is my fault we are missing `collect_similar` in the `DiskGenerator` implementation.

On the band the block looks like the whole axis (938?), so block iterate is the same as normal iterate

I think `map` should always `collect` first so we don't have this problem, and we should add `filter` for diskarrays that doesn't use `map` and is just not properly ordered,...

I think I just never thought to add that, rather than intentionally leaving it out. But sounds like it would be good to have.

Sorry, I can't remember why there is no bang. I guess we need both methods and the non-bang method to make a copy.