Rafael Schouten

Results 978 comments of Rafael Schouten
trafficstars

This is nice syntax: ```julia @getall Float64[x for x in obj if select(x)] # collects into a vector of Float64 ``` You could also use lenses: ```julia @getall [x.a for...

Transducers interop sounds good for a future PR. I probably have to leave that to you as I haven't had time to get my head around transducers yet.

The context that is harder to get is the parent object and field name (probably as a `StaticSymbol/StaticInt`). Fieldname is really useful for making `name => value` pairs e.g widget...

I've implemented `modify_stateful` and built `getall`, `setall` and `context` methods on it generally following the ideas from [this comment](https://github.com/JuliaObjects/Accessors.jl/pull/23#issuecomment-857360374). The structure seems pretty clean, although the generated function is still...

@jw3126 sorry I haven't had time for this in a while, just revisiting now. How do you feel about these options: 1. finish this with the current type instability 2....

Ok maybe we can do 1 and fix the performance things when we can. The (low key) urgency is that I'm keen to move on from using Flatten.jl in a...

Ok this is pretty much good to go. The last question is what to do with the `context` method and how to write `@modify` in relation to the generator syntax...

You need to define `ConstructionBase.constructorof` for any type where the parameters are not directly related to the fields.

Thanks! I never noticed because I never use it more than once, and only run the test once... It probably difficult to solve as there is some interaction with Unite...

It should be relatively simple to support both as its already in python - it can hook in directly skipping the vimscript component, if I understand the new plugin system...