Rafael Schouten

Results 1516 comments of Rafael Schouten

Yeah, maybe some checks still consider Dim{:X} and X to be different. We should maybe fix that

Yeah, we do need to resolve that inconsistency. It's just annoying to do and breaking. Theres an old PR #697 to swap to using traits rather than inheritance for XDim...

Yeah this time not an `AbstractParam` - just another wrapper type that works in exactly the same way otherwise. So you can just swap `Param` to `Const`. But e.g. it...

Not sure `nothing` is the best return value here. We could also just return the point from getgeom and ngeom could be 1 Or error

Error is pretty safe as we can always change it later, but returning `nothing` is permanent

Maybe `GI.getgeom(point, 1)` should return the point? a bit like how numbers work just returning themselves? Then `GI.ngeom(point)` should return `1`

We have `unmergedims` already, is that not enough?

Yeah that's too hard. let's make `unmergedims` work on anything.