primitives icon indicating copy to clipboard operation
primitives copied to clipboard

[Select] Add non modal mode in `popper` position

Open joaom00 opened this issue 2 years ago • 16 comments

Description

As suggested here https://github.com/radix-ui/primitives/pull/2004#issuecomment-1556985859, this PR adds non-modal mode only for the popper position since that mode for item-aligned position needs to be thought a little more.

Closes #1927

joaom00 avatar Jul 05 '23 15:07 joaom00

👋 @benoitgrelard! Any chance this PR could be looked into? It potentially fixes a rather serious performance issue – see https://github.com/radix-ui/primitives/issues/1634#issuecomment-1264347705 and below for details. I use Radix Select in a project via https://ui.shadcn.com/docs/components/select. When a page has heavy markup like a large table, clicking on select makes the app freeze even on a pretty recent MacBookPro with M1. The lag is especially visible in Safari, but it’s also noticeable on Chrome and FF (especially with x4 throttling).

kachkaev avatar Jul 29 '23 15:07 kachkaev

@joaom00 Olá! This is just a ping :slightly_smiling_face: is this PR/subject still alive?

frykten avatar Oct 10 '23 12:10 frykten

@frykten Yes definitely. Unfortunately, I think the team didn't have time to review the PR...

joaom00 avatar Oct 12 '23 17:10 joaom00

Came here from #2241

Thanks for the hint on onFocusOutside={ (event) => event.preventDefault() }. Might be a temporary, yet hacky solution, which is far from ideal.

Looking forward for this issue to be handled by the library itself.

SaveliiLukash avatar Dec 01 '23 10:12 SaveliiLukash

beep boop bump, this is a nice contribution – any chance it could get a review soon @benoitgrelard @andy-hook?

currently resorting to using DropdownMenu for the non-modal support when semantically I should be using Select

maschad96 avatar Feb 13 '24 14:02 maschad96

Any chance for this to be merged?

andreareginato avatar Mar 11 '24 08:03 andreareginato

I would also prefer it if this fix was checked and worked/merged. Is there anyway we can help to push it over the line?

CodingAleCR avatar Apr 27 '24 22:04 CodingAleCR

I am facing the same issue. Any updates on when this will be merged?

bmutahhar avatar May 06 '24 06:05 bmutahhar

Hi all! This is just a ping, any updates on a possible merge?

atancredi avatar Jun 13 '24 11:06 atancredi

Any..

donghoon-song avatar Jun 17 '24 05:06 donghoon-song