radicle-cli icon indicating copy to clipboard operation
radicle-cli copied to clipboard

Patch improvements

Open cloudhead opened this issue 3 years ago • 2 comments

While working through the patch workflow, we encounted some issues.

  • [x] rad-patch --list should fetch refs from monorepo, not working copy, so that it can be run anywhere
  • [x] rad-review doesn't have an option to sync review
  • [x] rad-patch --list doesn't have option to sync, so it's out of date unless you rad sync --fetch first
  • [ ] rad-patch pushes code before patch is confirmed
  • [x] rad-patch --list doesn't show branch names
  • [x] rad-remote rm has no output if it doesn't remove anything
  • [ ] rad-untrack should have the option to remove working copy refs/branches/remotes (on by default)
  • [ ] rad-track doesn't tell user that it setup branch and remote
  • [ ] rad-track --local should show non-default branches too (eg. patch feature branches)

cloudhead avatar Jun 30 '22 09:06 cloudhead

'rad-patch pushes code before patch is confirmed'

I recommend removing git-push confirmation from patch creation. Instead, either check and bail out if the code is uploaded with a flag to auto-push the code, or allow patch creation without requiring the code in radicle's local storage/monorepo.

The later option would be cool, but its harder if its even possible. Users would have more freedom to use radicle patches in their own way, with any git hosting system.

I prefer the former option for practicality. The action requires the code to be in local storage/monorepo at least ahead of any conceptual sanity checks; its a soft constraint. Therefor its somewhat implicit in patch creation.

slack-coder avatar Jul 28 '22 14:07 slack-coder

I agree about removing push confirmation, but in the case of auto-push, we're still pushing the code regardless of whether the patch is created or not. I guess it's less weird if there's no confirmation? Hmm, I'd have to look at it again.

cloudhead avatar Aug 01 '22 15:08 cloudhead