radar-sdk-ios icon indicating copy to clipboard operation
radar-sdk-ios copied to clipboard

sc-11053: Improve the Example app

Open jrtibbetts opened this issue 3 years ago • 3 comments
trafficstars

Note: converted to a draft PR because it includes the #196 changes.

sc-11053: [iOS SDK] Example app cleanup

  • Renamed the Example app to Radar Demo.
  • Instead of popping up notifications every time an event is received or a location is updated, every message is displayed with a timestamp in a simple table.
  • The Radar SDK calls have been put into the AppDelegate.runDemo() function, and they're run in the same order that they're listed in the Radar SDK documentation.

https://user-images.githubusercontent.com/708510/182423216-40512794-4927-4fe3-82ca-9c7d79be48a9.mp4

jrtibbetts avatar Aug 02 '22 16:08 jrtibbetts

This pull request has been linked to Shortcut Story #11053: [iOS SDK] Example app cleanup.

I think it'd be helpful to have some demarcation between successive calls - something like ========= or ---------, your call

Do you mean between where they're called in runDemo(), or between their declarations?

The last event says type = unknown - is deserializing the customType happening correctly?

I thought I fixed that in commit #8fb676. Maybe it needs to be added somewhere else, too.

do we want to indicate somewhere that we're running through all the SDK functions with the pasted in pub key? for fresh eyes this might not be obvious

Yeah, I buried that in the initializeSDK() call. Would it be enough to make it a top-level local variable, or a property on AppDelegate?

jrtibbetts avatar Aug 17 '22 01:08 jrtibbetts

I'm mainly assessing this from the perspective of someone who's just cloned the repo and running the Example app for the first time, viewing the output logs and trying to understand what happened

Do you mean between where they're called in runDemo(), or between their declarations?

Between output logs for each function - it'd be helpful to have a demarcation of where one call starts / ends

Yeah, I buried that in the initializeSDK() call. Would it be enough to make it a top-level local variable, or a property on AppDelegate?

Not sure what you mean in terms of placing it in code - I was thinking an initial log before the APIs are called, or indicating somewhere in the permission prompt

jsani-radar avatar Aug 17 '22 14:08 jsani-radar